-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename text_area
to textarea_field
#34
Comments
My dream DSL for this would probably be something like this: - text_field -> <input type="text">
- password_field -> <input type="password">
- hidden_field -> <input type="hidden">
- file_field -> <input type="file">
+ text_input -> <input type="text">
+ password_input -> <input type="password">
+ hidden_input -> <input type="hidden">
+ upload_file -> <input type="file">
check_box -> <input type="checkbox">
radio_button -> <input type="radio">
submit -> <input type="submit">
select -> <select>
text_area -> <textarea> However, I'm not sure it's worth the breaking change this would introduce to micromanage the DSL... @drujensen thoughts? |
@robacarp I really like that. I would also consider making this a standard naming convention and change the following as well:
wdyt? |
@westonganger I think |
Your right the @robacarp like your solution. I also prefer @drujensen drujensen additional suggestions. Another suggestion, after seeing |
file_input yeah, but my preference wouldn't be to suffix The reason I tagged text, password, and hidden with |
I personally would like to drop |
This one seemed to stick out. It should match all the other *_field methods. I would be happy to make a PR just need the goahead first. If so would we need to retain the legacy method for backwards compatibility?
The text was updated successfully, but these errors were encountered: