Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAA person birth/death sometimes are empty #2

Open
VladimirAlexiev opened this issue May 16, 2017 · 0 comments
Open

AAA person birth/death sometimes are empty #2

VladimirAlexiev opened this issue May 16, 2017 · 0 comments

Comments

@VladimirAlexiev
Copy link
Member

http://data.americanartcollaborative.org/page/aaa/person/5680/death is an empty Death node.
This record has DISPLAYDATEDIED "1945 or 1952" and no DIEDPLACE.

The reason is flawed conditional logic whether to make the URL:

DeathURI

From column: DISPLAYDATEDIED

if getValue("DIEDPLACE") or getValue("DISPLAYDATEDIED"):
    return getValue("ConstituentURI")+"/death"
else:
    return ""

But _BirthDateEarliest_ specifies that getValue("DISPLAYDATEBORN") is used only if that's exactly 4 chars. So the above value is treated as null, making the /death node useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants