Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider committing lockfile #229

Open
Imberflur opened this issue Apr 23, 2023 · 1 comment
Open

Consider committing lockfile #229

Imberflur opened this issue Apr 23, 2023 · 1 comment

Comments

@Imberflur
Copy link
Contributor

In #228 I ran into the issue of the CI failing due to a dependency with a higher MSRV. If we had a lockfile to pin dependencies this would not have occurred.

Ideally, we would have CI running with both the pinned versions and without the lockfile. Since we already test with multiple compiler versions, I think it would be suitable to use a lockfile for the MSRV toolchain, and the others could ignore the lockfile.
@Imberflur
Copy link
Contributor Author

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Imberflur