From 1b3218b7c8012c330c2186a8bce841a546dc8560 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20K=C3=A4hm?= Date: Thu, 19 Sep 2024 10:50:56 +0200 Subject: [PATCH] [BUGFIX] PhpStan Variable $parameters in empty() always exists and is not falsy Fixes PhpStan-issue: ``` ------ ----------------------------------------------------------------- Line Classes/System/Url/UrlHelper.php ------ ----------------------------------------------------------------- 52 Variable $parameters in empty() always exists and is not falsy. ------ ----------------------------------------------------------------- ``` --- Classes/System/Url/UrlHelper.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Classes/System/Url/UrlHelper.php b/Classes/System/Url/UrlHelper.php index ad5c858773..0ef3e918e9 100644 --- a/Classes/System/Url/UrlHelper.php +++ b/Classes/System/Url/UrlHelper.php @@ -48,10 +48,7 @@ public function withQueryParameter(string $parameterName, $value): UrlHelper { parse_str($this->query, $parameters); $parameters[$parameterName] = $value; - $query = ''; - if (!empty($parameters)) { - $query = http_build_query($parameters); - } + $query = http_build_query($parameters); $query = $this->sanitizeQuery($query); $clonedObject = clone $this; $clonedObject->query = $query;