Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request Feature] Rotation of words #210

Open
kakakhan2016 opened this issue Jan 2, 2017 · 5 comments
Open

[Request Feature] Rotation of words #210

kakakhan2016 opened this issue Jan 2, 2017 · 5 comments

Comments

@kakakhan2016
Copy link

Thanks for wonderful work. It would be nice if rotation of words feature can be added/coded. Is it possible?.

@amueller
Copy link
Owner

amueller commented Jan 2, 2017

Hey @kakakhan.
It's currently not possible to control the rotation of words more directly. Allowing per-word control of whether the rotation is 90 degrees or 0 degrees would be easy, but adding other rotations would be a little bit more work. Pull request welcome.

@vaastav
Copy link
Contributor

vaastav commented Oct 15, 2017

Hey @amueller I can try working on this in my spare time if that is ok with you? (Don't know if you remember me but I am the guy who contributed the initial conda package)

@amueller
Copy link
Owner

@vaastav which part? Arbitrary rotations or controlling for 90 degree rotations? Feel free to try either.

Btw, more help with packaging might be even better ;) The conda package has some issues and I have no time to look into it right now. There are issues both with conda-forge and the conda channel you created, I think at least missing Python 3.6 support. (I just want to emphasize that this is in no way a criticism of your previous contribution, really just asking for help :)

@vaastav
Copy link
Contributor

vaastav commented Oct 15, 2017

I'll try the 90 degree rotation first and then see if I can go ahead with arbitrary rotations.

I am not sure why the Conda thing is being an issue but I'll definitely take a look at it.

@amueller
Copy link
Owner

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants