Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to install grype from a local path #108

Closed
willmurphyscode opened this issue Aug 4, 2023 · 0 comments · Fixed by #111
Closed

make it possible to install grype from a local path #108

willmurphyscode opened this issue Aug 4, 2023 · 0 comments · Fixed by #111
Assignees
Labels
enhancement New feature or request

Comments

@willmurphyscode
Copy link
Contributor

What would you like to be added:

Right now, you can installed tools from a release or a pushed commit somewhere on GH. We should enable yardstick to "install" a tool by building it from a path.

Why is this needed:

Running make quality in grype has 2 unexpected behaviors right now:

  1. If your local commit isn't pushed to a remote, it will fail
  2. If you have uncommitted local changes, the tests will succeed, but will use grype built without those changes (because yardstick downloaded the last commit from GitHub.)

Number 2 could be especially frustrating to debug, and might surprise contributors.

@willmurphyscode willmurphyscode added the enhancement New feature or request label Aug 4, 2023
@willmurphyscode willmurphyscode self-assigned this Aug 4, 2023
@willmurphyscode willmurphyscode changed the title Tools should have a from_path install mode make it possible to install grype from a local path Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant