From 453aa2f85ea38198b6d9bc50c9c1942a1f16b6c3 Mon Sep 17 00:00:00 2001 From: Matthieu Darbois Date: Sat, 20 Jul 2024 17:06:31 +0200 Subject: [PATCH] Use MACOSX_DEPLOYMENT_TARGET=12.0 for macOS wheels (#6242) ### Description It seems the latests wheels aren't compatible with macOS 11 for some reason. We can't test on macOS 11 anymore & macOS 11 is EOL. Use MACOSX_DEPLOYMENT_TARGET=12.0 and move the tests to the lowest versioned runner available. Note: the delocate tool did not find anything wrong with the target being 11.0 on the 1.16.1 wheel. It should have complained if using symbols only compatible with 12.0+ so it seems MACOSX_DEPLOYMENT_TARGET=11.0 was indeed respected and the root cause of the issue is still unknown. ### Motivation and Context #6191 Signed-off-by: mayeut --- .github/workflows/release_mac.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release_mac.yml b/.github/workflows/release_mac.yml index c420cf3865b..63425350d9f 100644 --- a/.github/workflows/release_mac.yml +++ b/.github/workflows/release_mac.yml @@ -14,9 +14,9 @@ on: branches: [main, rel-*] workflow_dispatch: -# Use MACOSX_DEPLOYMENT_TARGET=11.0 to produce compatible wheel +# Use MACOSX_DEPLOYMENT_TARGET=12.0 to produce compatible wheel env: - MACOSX_DEPLOYMENT_TARGET: 11.0 + MACOSX_DEPLOYMENT_TARGET: "12.0" permissions: contents: read @@ -75,7 +75,7 @@ jobs: test: needs: build - runs-on: macos-latest + runs-on: ${{ (matrix.target-architecture == 'x86_64') && 'macos-12' || 'macos-14' }} strategy: matrix: python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] @@ -113,7 +113,7 @@ jobs: run: | arch -${{ matrix.target-architecture }} python -m pip uninstall -y numpy onnx arch -${{ matrix.target-architecture }} python -m pip install numpy - arch -${{ matrix.target-architecture }} python -m pip install --upgrade dist/*.whl + arch -${{ matrix.target-architecture }} python -m pip install --upgrade dist/*.whl arch -${{ matrix.target-architecture }} pytest - name: Verify ONNX with the latest protobuf @@ -128,7 +128,7 @@ jobs: if: always() && (matrix.target-architecture == 'x86_64' || (matrix.python-version != '3.8' && matrix.python-version != '3.9')) run: | arch -${{ matrix.target-architecture }} python -m pip uninstall -y numpy protobuf onnx - arch -${{ matrix.target-architecture }} python -m pip install -r requirements-min.txt + arch -${{ matrix.target-architecture }} python -m pip install -r requirements-min.txt arch -${{ matrix.target-architecture }} python -m pip install --upgrade dist/*.whl arch -${{ matrix.target-architecture }} pytest