From be6582caa5e9e3795a38268eb7010c2cbd19613c Mon Sep 17 00:00:00 2001 From: Andreas Fehlner Date: Sun, 25 Aug 2024 06:52:24 +0200 Subject: [PATCH 1/3] Bump actions/upload-artifact from 3 to 4 (#6319) ### Description Bump actions/upload-artifact from 3 to 4 ### Motivation and Context --------- Signed-off-by: Andreas Fehlner --- .github/workflows/release_linux_x86_64.yml | 2 +- .github/workflows/release_win.yml | 2 +- .github/workflows/scorecard.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release_linux_x86_64.yml b/.github/workflows/release_linux_x86_64.yml index e803a44ab17..6c86e5fc3ce 100644 --- a/.github/workflows/release_linux_x86_64.yml +++ b/.github/workflows/release_linux_x86_64.yml @@ -58,7 +58,7 @@ jobs: python -m pip install dist/*manylinux2014_x86_64.whl pytest - - uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b + - uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a with: name: wheels-${{ inputs.os }}-${{ matrix.python-version }} path: | diff --git a/.github/workflows/release_win.yml b/.github/workflows/release_win.yml index 6088669e7fd..c2f1953e555 100644 --- a/.github/workflows/release_win.yml +++ b/.github/workflows/release_win.yml @@ -77,7 +77,7 @@ jobs: cd onnx pytest - - uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b + - uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a with: name: wheels-${{ inputs.os }}-${{ matrix.python-version }}-${{matrix.architecture}} path: ./onnx/dist diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 8fccf6e61e6..614abac6632 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -63,7 +63,7 @@ jobs: # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF # format to the repository Actions tab. - name: "Upload artifact" - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.0 + uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a with: name: SARIF file path: results.sarif From 8171d36881b04b055c6ff871bd484bc71f85a564 Mon Sep 17 00:00:00 2001 From: Andreas Fehlner Date: Mon, 26 Aug 2024 16:02:35 +0200 Subject: [PATCH 2/3] Fix missing secrets for publishing of onnxweekly (#6321) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Description After the release-pipeline upgrade (https://github.com/onnx/onnx/pull/6277) the publishing the weekly does not work any more as the secrets are not available at the resuable workflows ( https://github.com/onnx/onnx/actions/runs/10551283959/job/29228497156 ) Link for the option I used for the secrets: https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows ### Motivation and Context In my opinion, we no longer need these secrets at the end. In the future, the publishing of the Onnx weekly builds will be solved via “trusted publishing” outside the individual OS release pipelines. This is already included in create_release.yml. Currently, the previous weeklys are published at pypi.org, in the test via trusted publishing at test.pypi.org After a successful schedule test (next Monday), we could adjust the publishing. a) e.g. throw out the upload steps with twine and adjust the target of separate steps... b) or leave it as it is for now... Signed-off-by: Andreas Fehlner --- .github/workflows/create_release.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml index 2763c70ed6a..6619c6b10e6 100644 --- a/.github/workflows/create_release.yml +++ b/.github/workflows/create_release.yml @@ -26,6 +26,7 @@ jobs: uses: ./.github/workflows/release_linux_x86_64.yml with: os: "linux_x86_64" + secrets: inherit call-workflow-ubuntu_aarch64: strategy: @@ -34,6 +35,7 @@ jobs: uses: ./.github/workflows/release_linux_aarch64.yml with: os: "linux_aarch64" + secrets: inherit call-workflow-win: strategy: @@ -41,7 +43,8 @@ jobs: os: ['windows-latest'] uses: ./.github/workflows/release_win.yml with: - os: "win" + os: "win" + secrets: inherit call-workflow-mac: strategy: @@ -49,7 +52,8 @@ jobs: os: ['mac-latest'] uses: ./.github/workflows/release_mac.yml with: - os: "macos" + os: "macos" + secrets: inherit @@ -70,7 +74,7 @@ jobs: steps: - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 with: pattern: wheels* path: dist From b17fa5b58c7195147ec8a8825607bff0d82fe893 Mon Sep 17 00:00:00 2001 From: Andreas Fehlner Date: Mon, 26 Aug 2024 20:18:54 +0200 Subject: [PATCH 3/3] Update main.yml (upgrade github actions download/upload artifact) (#6320) ### Description ### Motivation and Context --------- Signed-off-by: Andreas Fehlner --- .github/workflows/main.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 84d268a1275..749a50de4e0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -58,10 +58,10 @@ jobs: runs-on: ${{ matrix.os }} steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@9a9194f87191a7e9055e3e9b95b8cfb13023bb08 - name: Set up Python - uses: actions/setup-python@v5 + uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 with: python-version: ${{ matrix.python_version }} @@ -158,16 +158,16 @@ jobs: - name: Upload coverage to Codecov if: always() - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 with: token: ${{ secrets.CODECOV_TOKEN }} - name: Upload Test Results if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a with: - name: Test Results (${{ matrix.os }}-{{ matrix.python_version }}) - path: pytest.xml + name: TestResults-(${{ matrix.os }}-${{ matrix.python_version }}) + path: pytest.xml # Note that the test data should be generated with numpy>=2.0. # numpy 1.x and numpy 2.0 produce slightly different numerical values. @@ -219,11 +219,13 @@ jobs: if: always() steps: - name: Download Artifacts - uses: actions/download-artifact@v4 + uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 with: path: artifacts + pattern: TestResults* + merge-multiple: true - name: Publish Test Results - uses: EnricoMi/publish-unit-test-result-action@v2 + uses: EnricoMi/publish-unit-test-result-action@567cc7f8dcea3eba5da355f6ebc95663310d8a07 with: files: "artifacts/**/*.xml"