Use libphonenumber to properly format phone numbers #216
Conversation
|
/cc @blacksenator |
|
LGTM on quick glance. Would appreciate confirmation by @blacksenator |
|
I'll do this the next couple of days |
src/FritzBox/Converter.php
Outdated
| return $number; | ||
| $numberUtil = PhoneNumberUtil::getInstance(); | ||
| try { | ||
| $countryCode = $this->config['defaultCountry']; |
There was a problem hiding this comment.
$countryCode = $this->config['country'] ?? 'DE';
tests/ConverterTest.php
Outdated
| '@' => '', | ||
| '-' => '' | ||
| ], | ||
| 'defaultCountry' => 'DE', |
There was a problem hiding this comment.
analog config.example.php: 'country' => 'DE',
tests/RestorerTest.php
Outdated
| '/' => '', | ||
| '-' => '', | ||
| ], | ||
| 'defaultCountry' => 'DE' |
There was a problem hiding this comment.
@hanzi
Just to be sure:
The conversion may be in accordance with the ITU specifications - but can we also be sure that the FRITZ devices will process defined separators in foreign numbers?
This may not even happen for the vast majority of users - but using the library there is no longer any possibility for individual fine-tuning...
Listen to the FRITZ!Box Callmonitor only digits (apart from SIP) without any separators are displayed. Beside of this: unfortunately there is no AVM documentation which separators can be processed.
Have you tested with AVM devices whether the converted foreign numbers are initiating a dial out? For instance: test calls from the telephone book of a FRITZ!Fon or with a 'Wählhilfe' from the FRITZ!Box GUI?
Conversely, the central convenience function of identifying the caller using a stored telephone book in the FRITZ!Fon should not be lost when a (foreign) call is received.
As I said - possibly a marginal problem - but you never know ...
|
Contributer never updated reviewed topics. Beside of this: Apart from that, the implementation of the extensive library does not bring any real improvement over the manual solution in the config. I suggest to close this topic. |
hanzi
force-pushed
the
libphonenumber
branch
from
62a8c9d
to
b361953
Compare
|
Apologies, I must have missed the notification for the review in August. I've renamed the option from
I've been using this fork for half a year now, with various international numbers in my address book (from several European countries, India, Taiwan, USA, Vietnam) and never ran into any issues. Caller ID also works without issues, regardless of formatting in the address book. As far as I can tell, the Fritzbox happily ignores any whitespace/separators. But as you said, there doesn't seem to be any documentation for that.
I understand the hesitation for including another dependency. That's of course your decision. For me it works quite well and I've also been using it in some customer projects without any issues. My personal benefits with this solution:
|
This replaces the phone number formatting method using
strtr()with one that utilises the libphonenumber library (which is PHP port of the Google library with the same name.)That allows a user to just define the country code where the FRITZ!Box will be used and
libphonenumberwill handle the rest.It will automatically apply appropriate formatting for phone numbers and detect whether it's a national or international phone number. See the docblock for the method used:
https://github.com/giggsey/libphonenumber-for-php/blob/master/src/PhoneNumberUtil.php#L2643
Fixes #193