Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore duplicates #225

Open
LaCruz75 opened this issue Jan 19, 2021 · 3 comments
Open

Ignore duplicates #225

LaCruz75 opened this issue Jan 19, 2021 · 3 comments

Comments

@LaCruz75
Copy link

I using carddav2fb with two carddav-users to generate a family phone book.
Some contacts a similar, 'caus we ar knowing same persons.

It is possible to check for duplicate entrys?

Maybe helpfull: carlos22#23

@blacksenator
Copy link
Collaborator

blacksenator commented Jan 20, 2021

@LaCruz75:
As far as I can see, carlos22 did not implement the suggested change, but referred to duplicate merging in the source data.

Recommendation:
I myself and my wife have a comparable starting position. In addition to individual iCloud accounts, we use another shared account with the contacts that affect us both. This is also easy to maintain with CardBook for Thunderbird, for example.

Regardless of this:
The referenced diff only uses a simple comparison of the name as an indicator. This is certainly not difficult to implement, but is it really the (only) requirement? What are duplicates? Same name AND same phone number? Just the same name? Only the same number? Or ...?

@pucicu
Copy link

pucicu commented Dec 13, 2021

I strongly support this feature request. Would it be possible to add such a duplicate test (comparing name and phone number)?

@blacksenator
Copy link
Collaborator

@andig: If you have an idea for a general solution approach, I can try to realize a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants