Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssutil_modules/projucer_project.rb should only update specific shared files if requested #54

Open
andrewreeman opened this issue Mar 23, 2024 · 0 comments

Comments

@andrewreeman
Copy link
Owner

When projucer projects are updated using ssutil.rb the 'shared' file paths present in the base project are copied to all other projects. This recently led to a bug in which a release build of Morph would not build because it kept having it's dependency on 'SplineHelper.cpp' removed due to this copy. A related issue is that SpectralGate etc all now have a dependency on Spline.cpp which is not required.

We should remove non-required dependencies from all projects.
We should remove the automatic 'set_shared_group' functionality in 'ssutil_modules/projucer_project.rb'. This should not be called automatically.

Instead, we should create a new function called update_shared_group which is only called if requested via args. (something like --update-shared-files). What this should do is, instead of just replacing the 'shared' file group. It should only add files in the base shared file group that are not present in the projucer file we are updating. Perhaps in the future we could extend this to removing shared file dependencies too.

Example, Morph has a dependency on shared/SplineHelper.cpp and shared/Spline.cpp. And we add a new file to the base shared group called 'A.cpp'. When running ssutil.rb --update-shared-files then SplineHelper.cpp and Spline.cpp still exist in Morph's shared file group, but 'A.cpp' is also added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant