Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the project #9

Open
oneofmanylukes opened this issue Jul 18, 2019 · 9 comments
Open

Add tests to the project #9

oneofmanylukes opened this issue Jul 18, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@oneofmanylukes
Copy link
Contributor

Maybe some tests would be a good idea, because then you can see if your changes break anything or have other unexpected effects.

@Aleksbgbg
Copy link

If the codebase is to be tested, it must first be testable. For the codebase to be testable, we must refactor as per issue #4.

@oneofmanylukes
Copy link
Contributor Author

Sounds as it would be a good idea to refactor then.

@andrewyancey
Copy link
Owner

andrewyancey commented Jul 18, 2019

It’s already started it just needs to be merged into dev

@andrewyancey andrewyancey added the enhancement New feature or request label Jul 18, 2019
@andrewyancey
Copy link
Owner

Should we add a separate vs project for the test classes?

@oneofmanylukes
Copy link
Contributor Author

Isn't that the way it's usually done? As far as I can tell

@andrewyancey
Copy link
Owner

andrewyancey commented Jul 19, 2019

Yes but I believe it's also possible to do it in the same project. Just curious if you guys wanted the extra overhead of a second project.

Alternatively, I think we could have a testing branch so that only the people who want to run the tests have to pull them.

@Aleksbgbg
Copy link

Testing branch is a fair point, but it will require more synchronisation.

I don't think the second project adds any significant overhead - in fact, it prevents us from compiling test code into the release build.

@oneofmanylukes
Copy link
Contributor Author

I would also go with a second project for tests

@andrewyancey
Copy link
Owner

Alright let's go with the second project then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants