Added some nullability annotations to v4 #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmilnthorp
approved these changes
Nov 7, 2023
|
@angularsen looks like a NuGet failure in ADO. We should merge this into main also. |
|
Trying to get v4 branch to build on ADO. |
|
@ptasev Merged, sorry this took so long. It fell off my radar. The v4 branch has not been built in a long time and required some tweaks in the pipeline, but hopefully a nuget should be out shortly. Release UnitsNet/4.152.0 · angularsen/UnitsNet @tmilnthorp If you want to, see if we can merge this into master. I assume there will be some conflicts to sort out and I don't have the time to attempt that right now. |
|
Had to fix one more thing, but the nuget 4.152.0 is finally out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I treat warnings as errors, and when using the source generator from
System.Text.Jsonfor a type that hasUnitsNetproperties, it was generating code that had nullability warnings onBaseDimensionsandBaseUnitsforoperator ==.Since there's no good way to suppress this warning only for source generated code, the only way to fix this, short of disabling the warnings-as-errors across my whole project, is to add these annotations.