Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SiDecitonne mass unit of measure. #1333

Closed
wants to merge 5 commits into from
Closed

Added SiDecitonne mass unit of measure. #1333

wants to merge 5 commits into from

Conversation

IhorMukhortv
Copy link

No description provided.

@angularsen
Copy link
Owner

angularsen commented Dec 5, 2023

At first I was sure this was a typo 😄

  1. It seems the unit centner is also called quintal. Which name should we use?

  2. There are two different units with the same name. Do we need to add both? And should we name them so it is clear which unit we mean?

In British English, it referred to the hundredweight; in American English, it formerly referred to an uncommon measurement of 100 kg (220 lb).

https://en.wikipedia.org/wiki/Quintal

We have previously used gal (U.S.) vs gal (imp.) to disambiguate US and imperial units.
We could maybe use centner (U.S.) and centner (imp.) to match that, or similar for "quintal" if we go with that name.

https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#abbreviation-naming-conventions

@IhorMukhortv
Copy link
Author

IhorMukhortv commented Dec 5, 2023

At first I was sure this was a typo 😄

  1. It seems the unit centner is also called quintal. Which name should we use?
  2. There are two different units with the same name. Do we need to add both? And should we name them so it is clear which unit we mean?

In British English, it referred to the hundredweight; in American English, it formerly referred to an uncommon measurement of 100 kg (220 lb).

https://en.wikipedia.org/wiki/Quintal

We have previously used gal (U.S.) vs gal (imp.) to disambiguate US and imperial units. We could maybe use centner (U.S.) and centner (imp.) to match that, or similar for "quintal" if we go with that name.

https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#abbreviation-naming-conventions

I have found a suitable standardized name - 'decitonne.' I haven't delved into the details of the U.S. and Imperial measurement systems. In my opinion, there are two primary systems: Metric (or SI, as the modern variant) and Imperial. Considering that 'decitonne' could still cause confusion, I suggest adding 'decitonne (SI).' In the code, this might appear as 'SiDecitonne.'

If you have any further thoughts or concerns, please let me know, and we can proceed with the implementation. Thank you for your attention to detail!

It appears that 'Hundredweight' is not included in the PDF document provided in the Wiki under 'Adding a New Unit'.(https://unece.org/fileadmin/DAM/cefact/recommendations/rec20/rec20_rev3_Annex2e.pdf)

Best regards.

@IhorMukhortv IhorMukhortv changed the title Added centner mass unit of measure. Added SiDecitonne mass unit of measure. Dec 6, 2023
@IhorMukhortv
Copy link
Author

Hi, it's frustrating that my straightforward suggestion—just adding one unit of measurement to your structure—was overlooked. I'm disappointed in the lack of attention to such a simple improvement. I regret investing my time in this, but regardless, I wish you success in your development endeavors.

@IhorMukhortv IhorMukhortv deleted the add-centners-unit branch December 7, 2023 10:43
@angularsen
Copy link
Owner

@IhorMukhortv I think you need to adjust your expectations. This is the nature of many open source projects that are maintained on evenings and nights outside busy work life and family life. This was also not a simple improvement, there were questions and stuff to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants