Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RadiationEquivalentDoseRate base unit to Sv/s #1469

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Dec 25, 2024

Fixup of #1464

  • Add unit SievertPerSecond, for SI compatibility, with prefixes Nano, Micro, Milli
  • Change RadiationEquivalentDoseRate base unit from SievertPerHour to SievertPerSecond
  • Update conversion functions.

Add SI unit Sv/s and set as base unit, for SI compatibility
@angularsen angularsen changed the title Change RadiationEquivalentDose base unit to Sv/s Change RadiationEquivalentDoseRate base unit to Sv/s Dec 25, 2024
@angularsen angularsen enabled auto-merge (squash) December 25, 2024 20:29
angularsen added a commit that referenced this pull request Dec 25, 2024
Fixup of #1468
Port to v6 from #1469

- Add unit `SievertPerSecond`, for SI compatibility, with prefixes Nano, Micro, Milli
- Change `RadiationEquivalentDoseRate` base unit from `SievertPerHour` to `SievertPerSecond`
- Update conversion functions.
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84%. Comparing base (5c74f59) to head (f3438af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1469   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         349     349           
  Lines       33407   33439   +32     
======================================
+ Hits        28160   28192   +32     
  Misses       5247    5247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angularsen angularsen merged commit 1d1462a into master Dec 25, 2024
3 checks passed
@angularsen angularsen deleted the agl/sievertbase branch December 25, 2024 20:38
angularsen added a commit that referenced this pull request Dec 25, 2024
Fixup of #1468
Port to v6 from #1469

- Add unit `SievertPerSecond`, for SI compatibility, with prefixes Nano,
Micro, Milli
- Change `RadiationEquivalentDoseRate` base unit from `SievertPerHour`
to `SievertPerSecond`
- Update conversion functions.
@angularsen
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant