Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename only repair mode (quickly skip non matching files) #15

Closed
sjpotter opened this issue Aug 13, 2023 · 3 comments
Closed

rename only repair mode (quickly skip non matching files) #15

sjpotter opened this issue Aug 13, 2023 · 3 comments

Comments

@sjpotter
Copy link

sjpotter commented Aug 13, 2023

I currently ran into a situation where I accidentally renamed 1000 files (about 270GB in total) of files protected by multiple par2 sets (but all mixed together now).

It seems the only way to recover it is to iterate over every par2 file and pass in all the renamed files to the cmdline so it can see what can match.

However, it tries to do this to find blocks in all the files, so it scans them very slowly to do this.

I'm wondering if there would be better to have a "rename only" mode, where we make the assumption that the file really has no errors besides being renamd, so as soon as we see the start of the file doesn't match any of the files we expect, we can ignore it and move on, thereby saving huge amounts of IO.

similarly, once it found all the files complete and just need to rename, it can stop processing the rest of the file list passed in (as its just a rename, not a recovery, so we have all the data we need)

thoughts?

@animetosho
Copy link
Owner

Sounds like a neat feature, but would you be able to post it to the upstream project? If it gets implemented there, it'll get pulled down here.

@sjpotter
Copy link
Author

ok. didn't realize this was mostly focused on the math only, but that makes sense.

@animetosho animetosho closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@sjpotter
Copy link
Author

FYI: made a POC on upstream that works well for my needs - Parchive#185 but unsure how much movement actually happens on that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants