From fddf0b881d46a2c31d6b178aa7fdf3b728d88326 Mon Sep 17 00:00:00 2001 From: David Allison <62114487+david-allison@users.noreply.github.com> Date: Sun, 29 Sep 2024 18:06:33 +0100 Subject: [PATCH] improvement: better 'strings' message for maintainers We had a few times where the process was not followed correctly Improving the message should reduce the chance of this happening again Additional links further streamline the process for those who do not need the knowledge transfer Test results: https://redirect.github.com/david-allison/Anki-Android/issues/42#issuecomment-2381427055 Fixes 16980 Note: "PR" URL was changed in Issue 15887 ```diff - https://github.com/ankidroid/Anki-Android/pulls/app%2Fgithub-actions + https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount ``` --- .github/workflows/label.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/label.yml b/.github/workflows/label.yml index e63a7b53d60d..e02d05c4c48f 100644 --- a/.github/workflows/label.yml +++ b/.github/workflows/label.yml @@ -125,13 +125,12 @@ jobs: owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, - body: `Message to maintainers, this PR contains strings changes. - 1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out. - 2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves. - - Read more about updating strings on the wiki, - - [localization-administration](https://github.com/ankidroid/Anki-Android/wiki/Development-Guide#localization-administration) - - [download-localized-strings](https://github.com/ankidroid/Anki-Android/wiki/Development-Guide#download-localized-strings)` + body: `> [!IMPORTANT] + > **Maintainers**: This PR contains https://github.com/ankidroid/Anki-Android/labels/Strings changes + + 1. [Sync Translations](https://github.com/ankidroid/Anki-Android/actions/workflows/sync_translations.yml) before merging this PR and wait for the action to complete + 2. Review and merge the [auto-generated PR](https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount) in order to sync all user-submitted translations + 3. [Sync Translations again](https://github.com/ankidroid/Anki-Android/actions/workflows/sync_translations.yml) and merge the [PR](https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount) so the huge automated string changes caused by merging this PR are by themselves and easy to review` }) }