Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev content review 1 #1

Open
15 tasks done
gkwan-ibm opened this issue Mar 26, 2020 · 1 comment
Open
15 tasks done

Dev content review 1 #1

gkwan-ibm opened this issue Mar 26, 2020 · 1 comment

Comments

@gkwan-ibm
Copy link

gkwan-ibm commented Mar 26, 2020

  • :page-related-guides: add all other reactive guides and async guide
  • following descriptions are different. It is ok but make sure ID review the :page-description:
    • ":page-description: Learn various MicroProfile Reactive Messaging acknowledgement strategies available to acknowledge messages."
    • "Learn how to use MicroProfile Reactive Messaging acknowledgement strategies to acknowledge messages."
  • What you’ll learn
    • is the channel diagram needed?
    • add a statement to link to the MP reactive guide for readers to understand more MP reactive messaging and the OpenLiberty cafe application
  • MicroProfile Reactive Messaging Acknowledgement Strategies
    • "...URL[here^] in this table." -> like the following to spell out instead of here
      • "... in the table at the URL[Message acknowledgement^] section of the MicroProfile Reactive Messaging specification."
    • "NOTE : Method ...Message." -> "Methods ...message."
      • no need to have "NOTE:"
      • used "they", so I think plural for "Methods"
    • Building the Bar microservice with PRE_PROCESSING Acknowledgement strategy
      • "The receiveBeverageOrder() method in Bar microservice annotated with PRE_PROCESSING acknowledgement strategy matches the signature" -> "The receiveBeverageOrder() method in Bar microservice matches the following signature:"
      • "Based on the table mentioned URL[here^] ..." -> "Based on the table mentioned in the URL[specification^] ..."
        • Do not use here
      • add hotspot to "PRE_PROCESSING"
      • "the kafka" -> "the Kafka"
      • suggest to change following statement
        • "So if the service goes down when the message is being processed, the kafka won’t resend the message and the message would be lost."
        • to "In case, the service goes down when the message is being processed. When the service is restored, the Kafka won’t resend the message because the message was processed in the Kafka."
    • Building the Kitchen microservice with POST_PROCESSING Acknowledgement strategy
      • suggest to change following statement
        • "So if the service goes down when the message is being processed, the kafka will resend the message and the message will not be lost."
        • to "In case, the service goes down when the message is being processed. When the service is restored, the Kafka will resend the message because the message is not completed in the Kafka."
      • "If it does PRE_PROCESSING consider changing to POST_PROCESSING if you don’t want message to be lost." -> "If it does PRE_PROCESSING consider changing to POST_PROCESSING based on your application need."
  • BarService.java
    • format the lines better in the sendReadyOrder()
  • KitchenService.java
    • too many spaces to indent the lines in the prepareOrder()
  • create the draft github repo
@ankitagrawa
Copy link
Owner

What you’ll learn

is the channel diagram needed?

We should keep it. It further simplifies application for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants