Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to exit full-screen mode using the mouse #3647

Closed
jcznk opened this issue Dec 17, 2024 · 7 comments · Fixed by #3710
Closed

Provide a way to exit full-screen mode using the mouse #3647

jcznk opened this issue Dec 17, 2024 · 7 comments · Fixed by #3710

Comments

@jcznk
Copy link

jcznk commented Dec 17, 2024

Anki 24.11 (Qt6) Windows 11

Deck Browser and Reviewer: Full-screen mode can be enabled via View > Toggle Full Screen using the mouse. However, there appears to be no way to exit full-screen mode without using the keyboard.

In the Card Browser, this is not an issue because the top bar (Edit, View, Notes, Cards, Go, Help) remains visible even in full-screen mode.

Suggestion: In the Deck Browser and Reviewer, either keep the top bar visible during full-screen mode or display it when hovering over the top of the screen with the mouse.

@GithubAnon0000
Copy link

As another suggestion: Some apps also allow to right mouse click > Exit full screen for when the menubar is hidden.

@jcznk
Copy link
Author

jcznk commented Dec 21, 2024

I suggested modifying the behavior of the top bar for two main reasons:

  1. To improve accessibility. I worry that some users might accidentally enable full-screen mode while clicking around in the top bar and then struggle to exit it if they are unaware of the F11 shortcut. To address this, it would be helpful to retain the UI element they used to enter full-screen mode, making it easier for them to "find their way out".
  2. To make the Deck Browser and Reviewer behave more consistently with the Card Browser.

That said, I also like your right-click context menu suggestion and would personally be fine with either option or both.

By the way, I noticed that the top menubar does appear in the Reviewer while in full-screen mode, but only when hovering over the top/bottom bar with "Hide the top/bottom bar during review" set to 'Yes' in Preferences.

@KartikSharma0
Copy link

I have implemented your suggestions on keeping the menu bar while in full screen.

@YukiNagat0
Copy link
Contributor

YukiNagat0 commented Jan 1, 2025

Doesn't the menu bar already spawn when you hover to the top of the window in full screen in Deck Browser/Reviewer?
The code @KartikSharma0 changed in his PR has been around for ~3 years and there has been no negative feedback on it as far as I can remember. Everyone knows the F11 shortcut. If even users didn't know it, they would probably try hovering over the top of the window.

This issue addresses a problem that literally no one has experienced. The current implementation seems the most obvious and correct.

The whole purpose of full screen mode is to reduce the amount of distractions (in this case the menu bar). So it is a "by design" decision to hide it and show it only on hover.

@jcznk
Copy link
Author

jcznk commented Jan 2, 2025

Doesn't the menu bar already spawn when you hover to the top of the window in full screen in Deck Browser/Reviewer?

On my copy of Anki (24.11 for Windows 11, Qt6), this only works if Hide top/bottom bar during review is set to "Yes" in the Preferences. Otherwise, nothing happens when hovering at the top of the window. I didn't initially notice this discrepancy as I personally do not use the setting.

I can see how keeping the top menu bar always visible might be undesirable, as it kind of defeats the purpose of full-screen mode. My current suggestion is to make the top bar appear when hovering at the top of the screen, regardless of the Hide top/bottom bar during review setting.

@YukiNagat0
Copy link
Contributor

this only works if Hide top/bottom bar during review is set to "Yes" in the Preferences

Yeah, now I see the problem, thanks for clarification.

My current suggestion is to make the top bar appear when hovering at the top of the screen, regardless of the Hide top/bottom bar during review setting.

Was also thinking about this. Seems like a valid solution. I am even quite sure, that this combination (Fullscreen + Hide top/bottom bar during review is set to "Off") wasn't tested before and there is a flaw in the code (again, only in this combination).

@KartikSharma0
Copy link

Here's what I came up with as a fix for this issue, it includes a screen recording:
#3682 (comment)

Please share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants