Our build/CI formatting scripts can't handle modern Svelte syntax

[dae]

#3640 (comment)

I'll try to dig into this in the next few days. A temporary solution might be to execute prettier via a dprint exec plugin, instead of using the wasm version.

[dae]

Some other things have come up, so if you are interested in digging in to this @abdnh, you're most welcome. I see dprint-prettier-plugin just got an update, so that might be worth trying first, followed by dprint-plugin-exec to invoke prettier (so dprint still takes care of scanning through folders and locating changed files). If neither of those approaches work, then as a last resort we could invoke prettier directly and exclude those files from dprint.

[abdnh]

Here's what I tried:

1. Updating dprint-plugin-prettier didn't help. The plugin is actually using recent versions of prettier and prettier-plugin-svelte but it's failing to recognize new syntax, while running prettier directly with the same versions works interestingly...
2. I had trouble getting dprint-plugin-exec to work properly on Windows. It's not recognizing npx prettier even though it's in my path. Probably related to issues in std::process::Command (see Command::spawn has weird rules for finding binaries on Windows rust-lang/rust#37519)
3. Invoking Prettier directly works as expected: abdnh@d1c504c

[dae]

What about invoking node_modules/.bin/prettier directly? I don't think we use npx in the rest of our code. If you can't figure it out after a few minutes, would you be able to push your changes to a branch so I can have a brief play? Don't want to spend long on it, but figured it might be worth one more try before we go with 3.

[abdnh]

What about invoking node_modules/.bin/prettier directly?

It actually works, but we have to append .cmd on Windows: https://github.com/ankitects/anki/tree/prettier

would you be able to push your changes to a branch so I can have a brief play?

https://github.com/ankitects/anki/tree/dprint-exec

[dae]

Sorry Abdo, I think I made a bad call above. The exec plugin is likely going to result in a node startup for every file that's processed, which is likely going to be expensive. Approach 3 might be a best course forward.