Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source maps? #18

Closed
anko opened this issue Sep 25, 2015 · 2 comments
Closed

Source maps? #18

anko opened this issue Sep 25, 2015 · 2 comments
Labels
idea

Comments

@anko
Copy link
Owner

anko commented Sep 25, 2015

Requested by @IMPinball and @Paraknight on separate occasions.

Source maps are supplementary info attached to JS code that lets debuggers point at what other-language file some piece of JavaScript was compiled from, so humans can find what to debug. More here.

Related to #9, as both require a way to track where in the input source an internal AST node came from.
anko added a commit that referenced this issue Sep 25, 2015
@anko
Update for sexpr parser with object API
1682355 
Moving to parse s-expressions to objects is necessary for eventually
enabling returning also source-location information along with the
parsed nodes, for more informative errors (#9) and source maps (#18).
@anko anko added the idea label Sep 25, 2015
@avesus
Copy link

avesus commented Oct 23, 2015

👍

@anko anko closed this as completed in 337a95a Nov 25, 2015
@anko
Copy link
Owner Author

anko commented Nov 25, 2015

While not absolutely perfect, the source maps as merged in 337a95a are pretty much correct.

Sample visualisation (using this tool made by Tobias Koppers):

flyby of a visualisation

🎉🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avesus @anko