Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also validate newer estree nodes #57

Open
anko opened this issue Jan 16, 2020 · 0 comments
Open

Also validate newer estree nodes #57

anko opened this issue Jan 16, 2020 · 0 comments
Labels

Comments

@anko
Copy link
Owner

anko commented Jan 16, 2020

@vuolen noticed that newer estree nodes like ClassDeclaration were erroring when macros output them. I fixed that in a792d03 (published in 0.8.1) the best I can right now… which was by ignoring errors with estree nodes newer than esvalid understands. This should hold up fine technically, but it does mean newer estree nodes won't be sanity-checked before being passed to escodegen for code generation.

At time of writing, esvalid and esutils only understand nodes for standards up to and not including ECMAScript 2015 (i.e. ES6). Patches presumably welcome upstream at estools/esvalid#7 and estools/esutils#20.

@anko anko added the idea label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant