Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for disassemblies using mgbdis #1

Open
anmart opened this issue Oct 10, 2019 · 2 comments
Open

Add better support for disassemblies using mgbdis #1

anmart opened this issue Oct 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@anmart
Copy link
Owner

anmart commented Oct 10, 2019

Right now this script checks for unnamed symbols by searching for global addresses in the symbol name. mgbdis does bank_local syntax instead. Bolded items are completed (or replaced with a better feature)

  • Create switch that makes gbdprog check if (bank +"_" + localAddr) in label
  • Either allow alternate common labels (Func_, -> call_, etc) or search for everything using looping and eat the time cost
  • Change args to allow user to choose what label type to track. Currently it tracks Func_ with option enabled, but mgbdis doesn't even have Func_ so that's useless. Maybe do something similar to bank source and create a list of label types to track.
  • Remove Branches, that was special only the poketcg and shows up as x00 for other projects
@anmart anmart added the enhancement New feature or request label Oct 10, 2019
@anmart
Copy link
Owner Author

anmart commented Oct 10, 2019

Instead of the current "common - additional" format (which actually doesn't working for pokecrystal), it would be better to show everything by default and allow the user to either whitelist or blacklist label types.

@anmart
Copy link
Owner Author

anmart commented Oct 10, 2019

To add on to above - Whitelist and blacklist modes don't need to be mutually exclusive. Could have whitelists show up above everything else like the commons used to, while blacklists don't show up at all. Still with "Additional types" listed like normal.

Could also have default white/black list in the file as a global setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant