diff --git a/masp_primitives/src/transaction/components/sapling/fees.rs b/masp_primitives/src/transaction/components/sapling/fees.rs index c43395cb..93bf9497 100644 --- a/masp_primitives/src/transaction/components/sapling/fees.rs +++ b/masp_primitives/src/transaction/components/sapling/fees.rs @@ -2,8 +2,8 @@ //! of a transaction. use crate::asset_type::AssetType; -use crate::sapling::PaymentAddress; use crate::convert::AllowedConversion; +use crate::sapling::PaymentAddress; /// A trait that provides a minimized view of a Sapling input suitable for use in /// fee and change calculation. diff --git a/masp_primitives/src/transaction/components/transparent/fees.rs b/masp_primitives/src/transaction/components/transparent/fees.rs index 94836f05..cff0a544 100644 --- a/masp_primitives/src/transaction/components/transparent/fees.rs +++ b/masp_primitives/src/transaction/components/transparent/fees.rs @@ -2,8 +2,8 @@ //! of a transaction. use super::TxOut; -use crate::transaction::TransparentAddress; use crate::asset_type::AssetType; +use crate::transaction::TransparentAddress; /// This trait provides a minimized view of a transparent input suitable for use in /// fee and change computation. diff --git a/masp_primitives/src/transaction/txid.rs b/masp_primitives/src/transaction/txid.rs index 2bb14780..abede069 100644 --- a/masp_primitives/src/transaction/txid.rs +++ b/masp_primitives/src/transaction/txid.rs @@ -11,7 +11,7 @@ use group::GroupEncoding; use crate::consensus::{BlockHeight, BranchId}; use super::{ - sapling::{self, OutputDescription, SpendDescription}, + sapling::{self, ConvertDescription, OutputDescription, SpendDescription}, transparent::{self, TxIn, TxOut}, Authorization, Authorized, TransactionDigest, TransparentDigests, TxDigests, TxId, TxVersion, }; @@ -33,6 +33,8 @@ const ZCASH_SAPLING_SPENDS_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSSpendsHash" const ZCASH_SAPLING_SPENDS_COMPACT_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSSpendCHash"; const ZCASH_SAPLING_SPENDS_NONCOMPACT_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSSpendNHash"; +const ZCASH_SAPLING_CONVERTS_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdConvertHash"; + const ZCASH_SAPLING_OUTPUTS_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSOutputHash"; const ZCASH_SAPLING_OUTPUTS_COMPACT_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSOutC__Hash"; const ZCASH_SAPLING_OUTPUTS_MEMOS_HASH_PERSONALIZATION: &[u8; 16] = b"ZTxIdSOutM__Hash"; @@ -109,6 +111,24 @@ pub(crate) fn hash_sapling_spends( h.finalize() } +/// Implements ZIP 244-like hashing of MASP convert descriptions. +/// +/// Write disjoint parts of each MASP shielded convert to a hash: +/// * \[(cv, anchor)*\] - personalized with ZCASH_SAPLING_CONVERTS_HASH_PERSONALIZATION +/// +pub(crate) fn hash_sapling_converts( + shielded_converts: &[ConvertDescription], +) -> Blake2bHash { + let mut h = hasher(ZCASH_SAPLING_CONVERTS_HASH_PERSONALIZATION); + if !shielded_converts.is_empty() { + for s_convert in shielded_converts { + h.write_all(&s_convert.cv.to_bytes()).unwrap(); + h.write_all(&s_convert.anchor.to_repr()).unwrap(); + } + } + h.finalize() +} + /// Implements [ZIP 244 section T.3b](https://zips.z.cash/zip-0244#t-3b-sapling-outputs-digest) /// /// Write disjoint parts of each Sapling shielded output as 3 separate hashes: @@ -128,12 +148,18 @@ pub(crate) fn hash_sapling_outputs( for s_out in shielded_outputs { ch.write_all(s_out.cmu.to_repr().as_ref()).unwrap(); ch.write_all(s_out.ephemeral_key.as_ref()).unwrap(); - ch.write_all(&s_out.enc_ciphertext[..52]).unwrap(); + ch.write_all(&s_out.enc_ciphertext[..masp_note_encryption::COMPACT_NOTE_SIZE]) + .unwrap(); - mh.write_all(&s_out.enc_ciphertext[52..564]).unwrap(); + mh.write_all( + &s_out.enc_ciphertext[masp_note_encryption::COMPACT_NOTE_SIZE + ..masp_note_encryption::NOTE_PLAINTEXT_SIZE], + ) + .unwrap(); nh.write_all(&s_out.cv.to_bytes()).unwrap(); - nh.write_all(&s_out.enc_ciphertext[564..]).unwrap(); + nh.write_all(&s_out.enc_ciphertext[masp_note_encryption::NOTE_PLAINTEXT_SIZE..]) + .unwrap(); nh.write_all(&s_out.out_ciphertext).unwrap(); } @@ -194,10 +220,14 @@ fn hash_sapling_txid_data< bundle: &sapling::Bundle, ) -> Blake2bHash { let mut h = hasher(ZCASH_SAPLING_HASH_PERSONALIZATION); - if !(bundle.shielded_spends.is_empty() && bundle.shielded_outputs.is_empty()) { + if !(bundle.shielded_spends.is_empty() + && bundle.shielded_converts.is_empty() + && bundle.shielded_outputs.is_empty()) + { h.write_all(hash_sapling_spends(&bundle.shielded_spends).as_bytes()) .unwrap(); - + h.write_all(hash_sapling_converts(&bundle.shielded_converts).as_bytes()) + .unwrap(); h.write_all(hash_sapling_outputs(&bundle.shielded_outputs).as_bytes()) .unwrap();