Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting disappears while typing #44

Open
lukaszcz opened this issue Feb 16, 2023 · 12 comments · May be fixed by #142
Open

Highlighting disappears while typing #44

lukaszcz opened this issue Feb 16, 2023 · 12 comments · May be fixed by #142
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed high-priority syntax-highlighting

Comments

@lukaszcz
Copy link
Contributor

When you start typing and you haven't yet finished writing correct code, all highlighting disappears, including of the already correct code typed earlier. This is very annoying.

@lukaszcz lukaszcz added the bug Something isn't working label Feb 16, 2023
@jonaprieto
Copy link
Collaborator

jonaprieto commented Feb 16, 2023

@jonaprieto jonaprieto added the help wanted Extra attention is needed label Feb 16, 2023
@lukaszcz
Copy link
Contributor Author

Maybe one solution would be for the highlighter to highlight all it can even if there is a syntax error? But this probably requires significant changes in the Juvix highlighter.

@lukaszcz
Copy link
Contributor Author

But this is a bug. It's very annoying to use the VSCode extension because of this. It should be fixed one way or another.

But somehow it didn't happen with an earlier version, so something changed.

@jonaprieto
Copy link
Collaborator

Can you please track the version where it's supposed to be working?

@lukaszcz
Copy link
Contributor Author

Well, it doesn't seem to be working with any of the extension versions. Maybe the VSCode version changed or something changed in the juvix binary. Or I just misremembered this.

@lukaszcz
Copy link
Contributor Author

In any case, I would say this is the most serious issue with the VSCode extension as of now.

@lukaszcz
Copy link
Contributor Author

A solution might be not to update the highlighting if there is an error, but use the old highlighting if there is one?

@lukaszcz
Copy link
Contributor Author

lukaszcz commented Mar 9, 2023

My take on this is that if we can't easily have non-disappearing semantic highlighting, then it's better to have dumb highlighting like we currently have with JuvixCore and JuvixAsm.

@lukaszcz
Copy link
Contributor Author

lukaszcz commented May 25, 2023

This is partly solved in 0.1.39. Semantic highlighting still disappears while I'm typing after the position where I'm typing. If I make an error, depending on the kind of error, all semantic highlighting in the entire file may disappear, plus basic highlighting after the error point.

Ultimately, highlighting shouldn't disappear. It should behave more-or-less the way the Haskell extension behaves, where I guess the extension remembers things that were highlighted - at least that's how it looks from the user perspective.

@lukaszcz
Copy link
Contributor Author

image

@lukaszcz
Copy link
Contributor Author

image

@lukaszcz
Copy link
Contributor Author

Original state before editing:
image

@jonaprieto jonaprieto removed this from the 0.2 milestone Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed high-priority syntax-highlighting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants