From 01aaf1e8390458d7943c4af1a5ea6bac7ba39ef0 Mon Sep 17 00:00:00 2001
From: Alina Buzachis <abuzachis@redhat.com>
Date: Wed, 4 Dec 2024 18:34:27 +0100
Subject: [PATCH] Fix sanity

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
---
 plugins/modules/route53_ksk.py  | 9 +++++----
 plugins/modules/route53_zone.py | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/plugins/modules/route53_ksk.py b/plugins/modules/route53_ksk.py
index b0c52ccc6e..1e3c2f52c1 100644
--- a/plugins/modules/route53_ksk.py
+++ b/plugins/modules/route53_ksk.py
@@ -26,12 +26,12 @@
     caller_reference:
         description:
             - A unique string that identifies the request.
-        required: true
         type: str
     hosted_zone_id:
         description:
             - The unique string (ID) used to identify a hosted zone.
         type: str
+        required: true
         aliases: ["zone_id"]
     key_management_service_arn:
         description:
@@ -49,6 +49,7 @@
               You can set the value to V(ACTIVE) or V(INACTIVE).
         type: str
         default: "ACTIVE"
+        choices: ["ACTIVE", "INACTIVE"]
     wait:
         description:
             - Wait until the changes have been replicated.
@@ -125,7 +126,7 @@
     type: str
     sample: "https://route53.amazonaws.com/2013-04-01/keysigningkey/xxx/ansible-test-ksk"
 key_signing_key:
-    description:
+    description: The key-signing key (KSK) that the request creates.
     returned: only when a new Key Signing Request is created
     type: dict
     contains:
@@ -312,9 +313,9 @@ def main() -> None:
     argument_spec = dict(
         caller_reference=dict(type="str"),
         hosted_zone_id=dict(type="str", aliases=["zone_id"], required=True),
-        key_management_service_arn=dict(type="str", aliases=["kms_arn"]),
+        key_management_service_arn=dict(type="str", aliases=["kms_arn"], no_log=False),
         name=dict(type="str", required=True),
-        status=dict(type="str", default=["ACTIVE"], choices=["ACTIVE", "INACTIVE"]),
+        status=dict(type="str", default="ACTIVE", choices=["ACTIVE", "INACTIVE"]),
         state=dict(default="present", choices=["present", "absent"]),
         wait=dict(type="bool", default=False),
         wait_timeout=dict(type="int", default=300),
diff --git a/plugins/modules/route53_zone.py b/plugins/modules/route53_zone.py
index 5fdf453280..9aabd243c9 100644
--- a/plugins/modules/route53_zone.py
+++ b/plugins/modules/route53_zone.py
@@ -191,7 +191,7 @@
     type: dict
     contains:
         key_signing_key:
-            description:
+            description: The key-signing key (KSK) that the request creates.
             returned: when O(state=present)
             type: list
             elements: dict