From 8a29f2cb704134e9217c389f96508e354c76d192 Mon Sep 17 00:00:00 2001 From: Alina Buzachis Date: Wed, 4 Dec 2024 17:49:59 +0100 Subject: [PATCH] Minor updates Signed-off-by: Alina Buzachis --- plugins/modules/route53_ksk.py | 4 +++- plugins/modules/route53_zone.py | 16 ---------------- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/plugins/modules/route53_ksk.py b/plugins/modules/route53_ksk.py index 4a8eac14f7..b4550560f0 100644 --- a/plugins/modules/route53_ksk.py +++ b/plugins/modules/route53_ksk.py @@ -7,7 +7,7 @@ DOCUMENTATION = r""" module: route53_ksk short_description: Manages a key-signing key (KSK) -version_added: 5.0.0 +version_added: 9.2.0 description: - Creates a new key-signing key (KSK) associated with a hosted zone. You can only have two KSKs per hosted zone. @@ -63,6 +63,8 @@ - amazon.aws.common.modules - amazon.aws.region.modules - amazon.aws.boto3 +notes: + - This module does not support check_mode. author: - Alina Buzachis (@alinabuzachis) """ diff --git a/plugins/modules/route53_zone.py b/plugins/modules/route53_zone.py index 6f0c1443c7..d2d8b831e1 100644 --- a/plugins/modules/route53_zone.py +++ b/plugins/modules/route53_zone.py @@ -286,12 +286,10 @@ from ansible_collections.amazon.aws.plugins.module_utils.retries import AWSRetry from ansible_collections.amazon.aws.plugins.module_utils.route53 import get_tags from ansible_collections.amazon.aws.plugins.module_utils.route53 import manage_tags -from ansible_collections.amazon.aws.plugins.module_utils.waiters import get_waiter try: from botocore.exceptions import BotoCoreError from botocore.exceptions import ClientError - from botocore.exceptions import WaiterError except ImportError: pass # caught by AnsibleAWSModule @@ -368,20 +366,6 @@ def ensure_dnssec(client, module, zone_id): return changed -def wait(client, module, change_id): - try: - waiter = get_waiter(client, "resource_record_sets_changed") - waiter.wait( - Id=change_id, - WaiterConfig=dict( - Delay=5, - MaxAttempts=10, - ), - ) - except WaiterError as e: - module.fail_json_aws(e, msg="Timeout waiting for changes to be applied") - - def create(matching_zones): zone_in = module.params.get("zone").lower() vpc_id = module.params.get("vpc_id")