Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network-engine README.MD "should not be directly invoked" wording #238

Open
colin-mccarthy opened this issue May 26, 2019 · 3 comments

Comments

@colin-mccarthy
Copy link

ISSUE TYPE

  • Documentation Report

SUMMARY

I don't beleive the README.md should advise users not to invoke the network-engine role directly in a playbook. I suggest the removal of this wording.

It's a common practice to invoke the role at the beginning of the playbook, this wording also doesn't match with the later wording.

Any of the provided functions can be implemented in Ansible playbooks directly.

If you can use the functions in the playbook why can't you invoke the role in the playbook?

STEPS TO REPRODUCE

This role provides the foundation for building network roles by providing modules and plugins that are common to all Ansible Network roles. Typically this role should not be directly invoked in a playbook.

@trishnaguha
Copy link
Member

@abenokraitis
Copy link

The goal is to import the role, not to chop up the contents of the role. I think that's what the disclaimer is getting at. It is much easier to support a role that is imported, rather than using individual tasks within the role as part of the playbook.

@colin-mccarthy
Copy link
Author

It sounded to me like the author was suggesting you add this to the meta/mail.yml of the other network roles and not invoke this role by itself in a playbook. I'm okay with closing the issue if you think other folks will understand it the way you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants