Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Make ansibot less chatty #1081

Open
dagwieers opened this issue Oct 18, 2018 · 8 comments
Open

Make ansibot less chatty #1081

dagwieers opened this issue Oct 18, 2018 · 8 comments

Comments

@dagwieers
Copy link
Contributor

dagwieers commented Oct 18, 2018

I understand the need for presenting more information to (new) users, but having multiple comments added in close succession is a bit too much. Each comment induces another mail.

Example: ansible/ansible#47271 (comment)

For a typical new PR/issue we get:

  1. One comment to thank the user -- Can we do this only for new contributors ?
  2. One comment to cc related authors
  3. One coment to inform them of an existing WG

Each of these comments link to the ansibot help documentation.

Could we make ansibot smarter so it combines this information in a single comment ? Especially 1. and 3. seem a good introductionary blob, but I would also include the other authors by replacing cc @author1 @author2 with The following people are now notified of your issue/PR: @author1 @author2 (we could even make a distinction between maintainers and people notified in that message if that is deemed useful)

@webknjaz
Copy link
Member

I think that everyone deserves to be thanked.

As of other points, I 100% agree with those.

@gundalow
Copy link
Collaborator

Hi,
One thing that was discussed at Contributors Summit in Austin was that new issues/PR should get a single commented added along the forms of:


## Info for $AUTHOR
@person, thank you for this PR

If you are new to Contributing to Ansible then $LINK describes the process

If you'd like to add test see $LINK

If you get stuck, feel free to join us in #ansible-devel see $IRC_DOCS_LINK
## Info for Maintainers
The following people are listed as maintainers: $MAINTAINERS, can you please review this

## Working Group

This ISSUE/PR related to the following working groups...
* wg1
* wg2
LINK TO STUFF

## Info for other reviews

Testing of PRs is the best type of feedback, to download this patch do
$COMMAND_FOR_PSEUDO_BRANCH
see $DOCS_LINK

Please add comments saying if you've tested this and how it works

@dagwieers
Copy link
Contributor Author

@gundalow Perfect. I also wonder whether we can make this shorter for regular contributors. They don't need to be forwarded to working groups or being lectured about the process. It just adds more noise to the thread IMO. Less is more.

@webknjaz Being thanked by a bot doesn't feel very special to me. I don't think it's very flattery, but I can imagine new contributors are more affected by it.

@ckotte
Copy link

ckotte commented Oct 19, 2018

I prefer one email for a PR instead of three. It's also annoying that you get a single email for every single code comment, but I assume this is a Github thing and not related to ansibot.

@webknjaz
Copy link
Member

@ckotte yes, that's github's setting. You can configure that in your own notification settings.

@dagwieers

This comment has been minimized.

@gundalow
Copy link
Collaborator

@dagwieers yup, will do

gundalow added a commit to gundalow/ansibullbot that referenced this issue Nov 27, 2018
As this was posted as it's own comment, it was found to be a bit spammy.

The long term fix for this is to have a *single* message when Issues/PRs
are created, see
ansible#1081 (comment)
gundalow added a commit that referenced this issue Dec 3, 2018
As this was posted as it's own comment, it was found to be a bit spammy.

The long term fix for this is to have a *single* message when Issues/PRs
are created, see
#1081 (comment)
@gundalow
Copy link
Collaborator

gundalow commented Dec 5, 2018

"Thanks" message has been removed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants