Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty default credetial categories in launch template prompt #15708

Open
5 of 9 tasks
GuideGlyph opened this issue Dec 17, 2024 · 0 comments
Open
5 of 9 tasks

Hide empty default credetial categories in launch template prompt #15708

GuideGlyph opened this issue Dec 17, 2024 · 0 comments

Comments

@GuideGlyph
Copy link

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.

Feature type

New Feature

Feature Summary

Hide default empty credential categories from user template launch prompt.

User no need to see them or know about them if that types of credentials not in use.

Select the relevant components

  • UI
  • API
  • Docs
  • Collection
  • CLI
  • Other

Steps to reproduce

  1. Set credentials "Prompt on launch" option ON in template settings
  2. Launch template
  3. In Credentials page tap on select category list

Current results

User see list of all credentials types and my custom types

  • Amazon Web Services
  • Google Eompute Engine
  • Microsoft Azure Resource Manager
  • Openstack
  • Red Hat Ansible Automation Platform
  • Red Hat Satellite 6
  • Red Hat Virtualization
  • Terraform Backend Configuration
  • Vmware vCenter
  • Gpg Public Key
  • Openshift or Kubernetes API Bearer Token
  • Network
  • Machine
  • Vault
  • My type 1
  • My type 2

Sugested feature result

Display only credential types that not empty (and maybe user have permission to use)

  • Machine
  • Vault
  • My type 1

Additional information

In my scenario AWX user should run template jobs, select inventory then creds and limits

In credential tab he should tap select category, select custom one and then next page

When he open select category list he see all default credential types (amazon, google, openstack etc) even if there are empty and not in use. It be very cools to hide or delete them to make interface more clear and not overloaded.

I didnt find any way in settings how to hide them. API dont return disable option.

In file awx\ui\src\components\LaunchPrompt\steps\CredentialsStep.js in CredentialsStep we have flag isDisabled that always false. Maybe start use it.

            data={types.map((type) => ({
              key: type.id,
              value: type.id,
              label: type.name,
              isDisabled: false,
            }))}

Or maybe add to awx\ui\src\api\models\CredentialTypes.js check if type is empty.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant