Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Way to stop following ansible output #63

Closed
mathieumd opened this issue Sep 17, 2024 · 9 comments
Closed

Feature: Way to stop following ansible output #63

mathieumd opened this issue Sep 17, 2024 · 9 comments
Labels
enhancement New feature or request problem Problem

Comments

@mathieumd
Copy link

Scope

Frontend (User Interface)

Description

When you click the "Show Logs" button to watch Ansible output of a job, it's quite hard to close it back, as it's always moving/resizing its frame.

Maybe making it a little less high, to make sure the "Collapse" and "Stop Execution" buttons are always visible, could be a solution. And/or to use the Escape key to close the frame, too?

@mathieumd mathieumd added enhancement New feature or request triage Triage labels Sep 17, 2024
@mathieumd
Copy link
Author

Also, it would be nice to be able to scroll up the logs even if the job is not yet terminated. Currently, you can scroll a bit, but you are quickly put back at the bottom of the log. Frustrating! 😆

@ansibleguy
Copy link
Owner

  1. Have moved the target for the scrolling down a bit, so we can see the buttons
  2. We now have a refresh toggle-button
    image

@mathieumd
Copy link
Author

I refresh my browser cache, but I'm still getting the buttons under the footer:
2024-09-18_11-44

So I couldn't either test the Stop Scroll button, as it's constantly moving (which it's not when it's pause, of course 😉 ).

@superstes
Copy link

Please try it in a private tab. Maybe something was cached.
Which browser do you use?

@mathieumd
Copy link
Author

Firefox (v130.0), of course ;-)

  1. Buttons are still hidden behind the footer in a private window.
  2. I think I successfully clicked the (top of the) Stop Scroll button, but the scroll didn't stop.

@ansibleguy ansibleguy reopened this Sep 19, 2024
@ansibleguy
Copy link
Owner

Ok. Have tried it with chromium and firefox.
Is not refactored a bit:
image

The buttons are now fixed (always hover above the output)

@ansibleguy ansibleguy added problem Problem and removed triage Triage labels Sep 19, 2024
@mathieumd
Copy link
Author

mathieumd commented Sep 19, 2024

Oh, I'm sorry, it was my Nginx rewrite of /static/ which was still targeting the PyPI version...

It's working well.

I would add some CSS to move the buttons above other job's:

.aw-execution-logs-footer {
  position: fixed;
  bottom: 60px;
  right: 5vw;
  /*padding-left: 20px;*/
/* Adding something like that: */
  z-index: 9;
  background-color: white;
  padding: 5px 10px;
  border: 1px solid;
}

Screenshot_20240919_134023
Instead of:
Screenshot_20240919_134341

@ansibleguy
Copy link
Owner

Yeah.

Just tried 1h to get the damn buttons to vanish once they overflow the logs-container.. but no luck.
The 'fixed' position seems to be 'very special'. Not even 'z-index' is working.
CSS work really is not my favorite....

The only workaround I could think of, is using JS to check if the buttons overlap the logs-container and hide them if they are over or under the 'parent' container. But that's far from a 'clean' solution.

@ansibleguy
Copy link
Owner

Edit: Got it at last.. Buttons only shown inside the logs-container
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request problem Problem
Projects
None yet
Development

No branches or pull requests

3 participants