Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module install order #538

Open
5 of 7 tasks
bekjon-me opened this issue Jul 3, 2024 · 0 comments
Open
5 of 7 tasks

Module install order #538

bekjon-me opened this issue Jul 3, 2024 · 0 comments

Comments

@bekjon-me
Copy link

bekjon-me commented Jul 3, 2024

Describe the bug

I have a guard file as a module

import type { UserModule } from "@/types";

// Setup Pinia
// https://pinia.vuejs.org/
export const install: UserModule = async ({ router, isClient }) => {
  if (isClient) {
    const authenticated = JSON.parse(localStorage.getItem("authenticated") ?? "");

    router.beforeEach(async (to, from, next) => {
      if (to.meta.requiresAuth && !authenticated) {
        next("/login");
      } else {
        next();
      }
    });
  }
};

but this guard working a bit late. I think the problem is it is being installed later. When I try to go private page for example /clients page and I am not authenticated, clients page being shown and then it goes to /login. I tried this in index.html and everything works properly.Here is what I wrote in index.html

<script>
      (function () {

        const authenticated = JSON.parse(localStorage.getItem("authenticated"));
        if (
          (window.location.pathname === "/leads" ||
            window.location.pathname === "/clients") &&
          !authenticated
        ) {
          window.location.pathname = "/login";
        }
      })();
    </script>

I left the website as a reproduction so you can check yourself

Reproduction

ucrm.atmu.uz

System Info

Shell
Windows

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant