Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for .sql files #65

Closed
CrisVM opened this issue Sep 18, 2020 · 6 comments
Closed

Not working for .sql files #65

CrisVM opened this issue Sep 18, 2020 · 6 comments
Assignees

Comments

@CrisVM
Copy link

CrisVM commented Sep 18, 2020

Hi.

Since last update (done via Homebrew), .sql files don't work properly with QLColorCode anymore.

Maybe it's because of Highlight being also updated, but I'm not able to tell where the problem really is.

Any help will be greatly appreciated.

Thanks.
Cristiano

@CrisVM
Copy link
Author

CrisVM commented Sep 18, 2020

I just realized .asp and .txt files don't work as well. There may be more file types not working... 😕

.txt file (not rendering through QLColorCode):
ZION³ 2020-09-18 at 16 46 26

.sh file (working as expected):
ZION³ 2020-09-18 at 16 46 57

@anthonygelibert
Copy link
Owner

Hi.

Since last update (done via Homebrew), .sql files don't work properly with QLColorCode anymore.

Maybe it's because of Highlight being also updated, but I'm not able to tell where the problem really is.

Any help will be greatly appreciated.

Thanks.
Cristiano

Can you provide me an SQL file that is not working, please? I can't reproduce locally the problem.

@anthonygelibert
Copy link
Owner

anthonygelibert commented Sep 21, 2020

I just realized .asp and .txt files don't work as well. There may be more file types not working... 😕

For TXT, it's not a bug but a feature ;-) (see #48, I removed the TXT file support in favor of QLStephen). For ASP, can you provide me a file, please ?

@CrisVM
Copy link
Author

CrisVM commented Sep 23, 2020

Hi @anthonygelibert

Sorry for the late reply...

Inside this zip file, there are 2 files: sample.asp, and sample.sql
samples.zip

Please, take a look at the following screenshot:
ZION³ 2020-09-23 at 01 16 15

As you can see, there's a reason for .asp files not use QLColorCode... :-) I'm just not sure how to "fix" it...

Does it have anything to do with editing the Info.plist file? (as described in the README.md)

If so, is this the same procedure I have to do in order to make .txt files use QLColorCode as well?

And then there's the .sql files that still make me wonder what's going on...

If you need further details, please let me know.

Thank you so much for your time.
Cristiano.

@CrisVM
Copy link
Author

CrisVM commented Sep 23, 2020

Hi again.

I kind of "fixed" everything but .sql files to my liking...

I just edited Info.plist adding these lines inside the LSItemContentTypes array:

	<string>public.plain-text</string>
	<string>public.data</string>
	<string>public.content</string>

And then I uninstalled QLStephen, 'cause these edits made QLColorCode render everything that QLStephen would, so I don't need it anymore... :-)

The only files that are still "broken": .sql

Any news on this?

Thanks again.
Cristiano.

@CrisVM
Copy link
Author

CrisVM commented Sep 23, 2020

Update:

I don't know why, but now .sql files work as expected. 8-)
ZION³ 2020-09-23 at 13 31 03

Maybe there was some cache going on... I don't know.

Anyway, thank you so much for taking the time to look at this issue for me. I really appreciate it!

Cheers.
Cristiano.

@CrisVM CrisVM closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants