Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] ESLint config #102

Open
kevinpruett-prime opened this issue Aug 21, 2024 · 0 comments
Open

[Question] ESLint config #102

kevinpruett-prime opened this issue Aug 21, 2024 · 0 comments

Comments

@kevinpruett-prime
Copy link

kevinpruett-prime commented Aug 21, 2024

Are these scripts

{
  "scripts": {
    "lint": "turbo lint --continue",
    "lint:fix": "turbo lint:fix --continue"
  }
}

meant to replace [the following]?(https://github.com/anthonyshew/maestros/blob/main/apps/maestros/content/maestros/lessons/guardrails/eslint.mdx?plain=1#L187-L191):

  "scripts": {
    "lint": "eslint . \"!apps/** !packages/** !tooling/**\" --cache --cache-location 'node_modules/.cache/.eslintcache' --max-warnings 0",
    "lint:fix": "eslint . \"!apps/** !packages/** !tooling/**\" --fix --cache --cache-location 'node_modules/.cache/.eslintcache' --max-warnings 0"
  },

Wouldn't we still need to define how to run eslint with the negative glob patterns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant