Fix for #4177 -- kotlin/kotlin/pom.xml and grammars.json #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaby76
changed the title
|
@kaby76 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the top-level lexer grammar for kotlin/kotlin as listed in the pom.xml. The
<include>element should only be for top-level grammars, not imported. UnicodeClasses.g4 is an imported grammar, but it is listed in the pom.xml to be processed by the tool.The grammars.json file is a list of all grammars in this repo for testing in lab.antlr.org. It contains an error for the kotlin grammar because of the pom error. The file has been regenerated to fix antlr/antlr4-lab#92; the grammars.json file is computed by mkindex.py.