Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Modes.DEFAULT_MODE to Modes.DEFAULT in the Kotlin runtime and target #10

Open
ftomassetti opened this issue Jan 25, 2024 · 1 comment
Assignees

Comments

@ftomassetti
Copy link
Collaborator

Currently we generate this code for the Kotlin target:

object Modes {
  const val DEFAULT_MODE = 0
  const val FOO = 1 // made uppercase by #8 
  const val BAR = 2
}

This is inconsistent because only the default mode has the _MODE suffix. We should therefore rename it, by working on the template for the Kotlin target and updating references in the Kotlin runtime

@ftomassetti
Copy link
Collaborator Author

I would assign the issue to me, but I have no permissions for doing so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant