Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlight node related lines #391

Closed

Conversation

StrangeXin
Copy link

Description

修复问题:XFlowNodeCommands.HIGHLIGHT_NODE 高亮节点命令,isHighlightRelatedLines参数功能不正确

问题1:getEdges是获取全部边,应该改为getConnectedEdges

问题2:在allEdges.forEach里面执行HIGHLIGHT_EDGE,会导致只高亮最后一条边,因为HIGHLIGHT_EDGE命令一次只高亮一条边,并且会将其他边重置为非高亮

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: 2be488c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xflow-bot xflow-bot bot added PR: unreviewed PR does not have any reviews. pkg:docs Denotes a PR that changes packages/xflow-docs pkg:xflow-core Denotes a PR that changes packages/xflow-core size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2023
@StrangeXin
Copy link
Author

另外:
1、XFlowNodeCommands.HIGHLIGHT_NODE 高亮节点命令的isHighlightRelatedLines参数应该去除或增加一个options参数,用于改为getConnectedEdges后需要传额外的参数
image
这里感觉isHighlightRelatedLines很鸡肋
2、当我需要一次高亮很多个节点或者很多条指定的边,目前没有这样的命令,目前都是只能够传一个节点或边的id(更加不科学的地方:HIGHLIGHT_EDGE只高亮一条边,并且还会重置掉其他已经高亮的边,这也是上面Description“问题2”产生的原因),建议增加一个批量高亮节点或边的命令

@xflow-bot
Copy link
Contributor

xflow-bot bot commented May 30, 2023

Hiya!

This PR has gone quiet. Spooky quiet. 👻

We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!

Thanks for being a part of the AntV community! 💪💯

@xflow-bot xflow-bot bot added the stale Issue that may be closed soon due to the original author not responding any more. label May 30, 2023
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Jul 9, 2023

Hey again!

It’s been 60 days since anything happened on this PR, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot 🤖, so if I’ve closed this PR in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this PR or create a new one if you need anything else.

Thanks again for being part of the AntV community! 💪💯

@xflow-bot xflow-bot bot closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:docs Denotes a PR that changes packages/xflow-docs pkg:xflow-core Denotes a PR that changes packages/xflow-core PR: unreviewed PR does not have any reviews. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stale Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant