Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default variables to be passed #4

Open
bebraw opened this issue May 21, 2015 · 4 comments
Open

Allow default variables to be passed #4

bebraw opened this issue May 21, 2015 · 4 comments

Comments

@bebraw
Copy link
Member

bebraw commented May 21, 2015

I tried overwriting some of the default values through the custom styles hack (primarily content width). I realized it would be a much better idea to be able to provide custom configuration to themes (ie. pass name of file containing variables or json/js conf even). Do you want me to give it a go?

Btw that custom style thing should probably go to a higher level. It's not nice that themes have to inject it.

@eldh
Copy link
Member

eldh commented May 21, 2015

Yes, the custom styles thing should definitely be re-written and take advantage of webpack @import support, that just landed in sass-loader, not a nice solution atm. That should also make it much nicer to override the default vars.

Have to look over it a bit more to see the best way to solve this.

@eldh
Copy link
Member

eldh commented May 21, 2015

Do we need more theme config than what you can set in antwar.config?

@bebraw
Copy link
Member Author

bebraw commented May 21, 2015

Do we need more theme config than what you can set in antwar.config?

Not sure. I guess we can start from that. No need to be perfect at the first go.

@eldh
Copy link
Member

eldh commented May 21, 2015

I think there's a point in not adding too much complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants