Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign In" doesn't do the plugin related OAuth so I get precondition required #979

Closed
A11st0r opened this issue Nov 15, 2024 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@A11st0r
Copy link

A11st0r commented Nov 15, 2024

Context

I remember the sign in once did an OAuth dance for the Kodi Youtube Plugin and once for the OAuth Client made by the user with Google Cloud. It does only the latter. I get success via the google.com/device but failure on Kodi GUI.

  • Add-on Version: 7.1.1
  • Kodi Version: Kodi Media Center 20.2 (20.2.0) Git:20230630-5f418d0b13
  • Kodi GUI Language: English
  • Operating System: Ubuntu 22.04.3 LTS
  • Operating System Language: English

Expected Behavior

Successful Sign in


Current Behavior

Failed Sign in with red X


Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Install Kodi on Ubuntu
  2. Install Youtube addon using the zip file
  3. Sign in on the addon
  4. follow google.com/device instructions

Log

Please include a complete debug log.

https://paste.kodi.tv/ojilapahax.kodi


Additional Information

To be clear I can see my client consent screen following google.com/device and it shows success there.

If clean reinstall mean uninstalling and deleting temp via maintenance menu and even deleting .kodi/userdata/addon_data/plugin.video.youtube I did them.


@A11st0r A11st0r added the bug Something isn't working label Nov 15, 2024
MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Nov 15, 2024
@MoojMidge
Copy link
Collaborator

Silly mistake. Thanks for the log.

Can you confirm that the sign-in works using the following version?
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/v7.1.1.zip

@balgerion
Copy link

I had exactly same issue like OP, after installing version from ZIP , everything is working. Thank you :)

@DjDiabolik
Copy link
Contributor

@MoojMidge apparently i have a similar issue....
About 5 minutes ago open Kodi on my Ubuntu 24.04.1 LTS whit kodi flatpak and update the addons from repo to 7.1.1 unofficial.
Installation it's ok...
Apparently i need to relogin my account... and i try to complete both procedure:

  • Register to obtain first code
  • Open google.com/device from my phone
  • Put the code appear on TV
  • Click on Advanced and after click to accept the connection
    On TV it's appears an error report on kodi.log:
    https://paste.kodi.tv/efosorewom.kodi

If it's correct i need to install the same 7.1.1 from your repo..... You have to update this to this anxdpanic repo and push it to a unofficial and upgraded version ?

@DjDiabolik
Copy link
Contributor

@MoojMidge can also i confirm... istalled this:
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/v7.1.1.zip

Resolve the issue.....

@MoojMidge
Copy link
Collaborator

You have to update this to this anxdpanic repo and push it to a unofficial and upgraded version ?

The previously linked zip file is just a test version with a fix for this specific problem.

There are some changes to the data stored in access_manager.json that caused this and at least one other problem.

Once the fixes are confirmed as working a v7.1.1.1 will be released

@yggdr
Copy link

yggdr commented Nov 15, 2024

Hello MoojMidge. I might have problems that are related, but I'm not sure. 2 days ago it started to not being able to play videos anymore. After trying around and installing 7.1.1, and then the other 7.1.1 you linked above, it still wouldn't work, with YouTubeException('"error" in response JSON data') and Message: The caller does not have permission in kodi.log

With your modified 7.1.1 installed, I signed out and tried to sign in again, but I get

2024-11-15 22:35:53.993 T:23120    info <general>: [plugin.video.youtube] Plugin: Running v7.1.1
                                                        Kodi:   v21.1 (Kodi Omega)
                                                        Python: v3.9.2
                                                        Path:   |/sign/in/|
                                                        Params: |{'category_label': 'Sign In'}|
2024-11-15 22:35:57.155 T:23120   error <general>: [plugin.video.youtube] Login Failed: Unknown response
                                                        Device/user code request - Failed
                                                        Exception: LoginException('"error" in response JSON data')
                                                        config_type: |YouTube-Kodi|
                                                        client_id:   |480...t.com|
                                                        Response:   {'error': 'invalid_client', 'error_description': 'Invalid client type.', 'code': 401}
2024-11-15 22:35:57.159 T:23120   error <general>: [plugin.video.youtube] LoginException: {'error': 'invalid_client', 'error_description': 'Invalid client type.', 'code': 401}

Is this related to this error, or should I open a separate issue?

@MoojMidge
Copy link
Collaborator

Is this related to this error, or should I open a separate issue?

This is a separate issue, but it is due to incorrectly configured OAuth credentials.

You can refer to the instructions here for how to create this correctly:
#439 (comment)

Pay particular attention to Step 10.

@MoojMidge MoojMidge mentioned this issue Nov 15, 2024
@MoojMidge
Copy link
Collaborator

Fix is now available in v7.1.1.1
https://github.com/anxdpanic/plugin.video.youtube/releases/tag/v7.1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants