Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to configure redis sentinel is nebulous and documentation is missing #206

Open
josh-m-sharpe opened this issue Sep 5, 2024 · 1 comment

Comments

@josh-m-sharpe
Copy link

Tell us about your environment

docker

AnyCable-Go version:
anycable/anycable-go:1.5.3

What did you do?

tried finding explicit documentation for connecting to redis sentinels but they are not present here: https://docs.anycable.io/anycable-go/configuration?id=redis-configuration
found related changelog entry:
https://github.com/anycable/anycable-go/blob/master/CHANGELOG.md#101-2020-07-07

But then I see there's no EnvVars thing (sorry, my go sucks) in https://github.com/anycable/anycable-go/blob/master/cli/options.go#L543-L546 for the sentinel config, so makes me second guess that changelog entry or the viability of using ANYCABLE_REDIS_SENTINELS

Would be amazeballs if I could use env vars to connect to redis sentinel and the docs could reflect that information. Thank you!

@palkan
Copy link
Member

palkan commented Sep 17, 2024

Thanks for reporting!

Yeah, we have the configuration properly covered at the Ruby side: https://docs.anycable.io/ruby/broadcast_adapters?id=redis-sentinel-support

It's the same for the Go server, meaning the env var works (there's no EnvVars thing because we do that implicitly—convention over configuration appleid to Go:

func withDefaults(category string, flags []cli.Flag) []cli.Flag {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@josh-m-sharpe @palkan and others