Extract solana-account crate #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
account-crate
branch
from
3fd2568
to
0dac686
Compare
kevinheavey
force-pushed
the
account-crate
branch
2 times, most recently
from
a9a878b
to
6dfd50e
Compare
kevinheavey
force-pushed
the
account-crate
branch
2 times, most recently
from
f187e31
to
55524a0
Compare
kevinheavey
commented
Oct 3, 2024
| edition = { workspace = true } | ||
|
|
||
| [dependencies] | ||
| bincode = { workspace = true, optional = true } |
There was a problem hiding this comment.
Making serde and bincode optional won't remove those dependencies for now as solana-program still pulls them in, but by feature gating them from the start we avoid any breaking changes. In a later PR we'll remove the solana-program dep from this new crate
kevinheavey
force-pushed
the
account-crate
branch
from
98282d0
to
9940d43
Compare
This was referenced Oct 5, 2024
kevinheavey
force-pushed
the
account-crate
branch
from
9940d43
to
7880055
Compare
|
Great! @yihau I've sent a crate ownership invite to anza-team |
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having the contents of
solana_sdk::accountavailable outside the SDK would help compile times and dependency hell. The most immediate unlock would be removing the solana-sdk dep from solana-account-decoder-client-types (created in #2872)Summary of Changes
account.rsto its own crate