Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code modernisation #27

Closed
aosprey opened this issue May 25, 2023 · 1 comment · Fixed by #31
Closed

Code modernisation #27

aosprey opened this issue May 25, 2023 · 1 comment · Fixed by #31

Comments

@aosprey
Copy link
Owner

aosprey commented May 25, 2023

There are still some outdated language features in the code that should probably be updated for i) future-proofing and ii) ease of use.

  • #ifdef : Some of this functionality can done with IF clauses in the code, and different versions of routines if required, but this may mean specifing paramters at runtime versus compile time. The #ifdefs generally occur at a higher level (now that the CAM coupling has been removed) so it probably wouldn't affect performance.
  • DATA : The way these are used, we can just replace with normal array assignment.
  • RETURN at end of SUBROUTINE blocks : This is redundant.
  • CONTINUE and GOTO in loops : We can re-write these with a standard loop structure.
@aosprey aosprey linked a pull request May 30, 2023 that will close this issue
@aosprey
Copy link
Owner Author

aosprey commented May 30, 2023

Partially solved by above branch. Goto and continues are more complicated - so moved to #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant