Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into using ZookeeperTestingServer to test ZooCache #5048

Open
keith-turner opened this issue Nov 8, 2024 · 0 comments
Open

Look into using ZookeeperTestingServer to test ZooCache #5048

keith-turner opened this issue Nov 8, 2024 · 0 comments

Comments

@keith-turner
Copy link
Contributor

In the following comment an experimental IT was written to test ZooCache performance.

#5040 (comment)_

While that performance test would not be suitable for an IT, it may be good to write an IT that test ZooCache correctness in a similar way to that test. There is a fairly extensive zoo cache unit test that uses mocking. It would be better to move a subset of those test to use a real zookeeper. That unit test assumes that when a node has zero children in zookeeper that null is returned which is not the case see #5047. The ZookeeperTestingServer is really fast so running the test would not take longer, but the test would be more accurate than mocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant