Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escaping from external compaction entries in metadata table #5060

Open
keith-turner opened this issue Nov 13, 2024 · 1 comment
Open
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@keith-turner
Copy link
Contributor

Is your feature request related to a problem? Please describe.

External compaction entiries in the metadata table are json and include the files that are being compacted. The files in the json are also json and when added to the outer json as values are escaped.

Describe the solution you'd like

Not sure if its possible, but it would be nice to remove the escaping for the file entries if possible.

Describe alternatives you've considered

Could do nothing, the escaping is very unpleasant to look at when scanning he metadata table but its not hurting anything. The escaping may make using tools like jq w/ the data a bit harder also.

@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label Nov 13, 2024
@keith-turner keith-turner added this to the 4.0.0 milestone Nov 13, 2024
@cshannon
Copy link
Contributor

I took a look at this and was thinking a bit about it and the only really good way to get rid of the escaping would be to not use the serialized json string of the files and instead use an object representation of StoredTabletFile, but that would break the encapsulation of StoredTabletFile and expose the file/range outside of it so I'm not sure if that's a great idea. A custom serializer would be tricky because escaping quotes are needed so it's valid json.

I'm wondering if this is something that is better solved as custom logic when scanning and logging to print it out in an easier to read format vs storing it differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

No branches or pull requests

2 participants