Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search result highlighting is broken in docs #237

Open
ashb opened this issue Jan 30, 2020 · 1 comment
Open

Search result highlighting is broken in docs #237

ashb opened this issue Jan 30, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ashb
Copy link
Member

ashb commented Jan 30, 2020

If you search for a string in the docs then the occurrences of the search string on the page will be wrapped in <span class="highlight"> -- currently we don't style this.

The "default" style for the previous theme was to set the background colour for this tag -- we should just pick a "nice" colour.
@ashb ashb added the good first issue Good for newcomers label Jan 30, 2020
@ryw ryw changed the title Style "higlight"/search result in docs Style "highlight"/search result in docs Oct 12, 2020
@ryw ryw changed the title Style "highlight"/search result in docs Search result highlighting is broken in docs Oct 12, 2020
@ryw ryw added the bug Something isn't working label Oct 12, 2020
@ryw
Copy link
Member

ryw commented Oct 12, 2020

@ryanahamilton maybe you could fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryw @ashb