Fix kubernetes executor watcher kube_client_request_args shadowing #45528
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
insomnes
force-pushed
the
kexec-watcher-req-args
branch
2 times, most recently
from
4c73b7c to
d62734a
Compare
insomnes
force-pushed
the
kexec-watcher-req-args
branch
from
d62734a to
3177e52
Compare
|
I've checked failed tests in previous checks run And I can't find any reason for my changes to interfere with them. So I've rebased branch again |
RNHTTR
reviewed
Jan 10, 2025
providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
RNHTTR
requested changes
Jan 10, 2025
…rnetes_executor_utils.py Apply suggestion by review Co-authored-by: Ryan Hatter <[email protected]>
|
Added as suggested. I am not familiar with code standards, so I was trying to minimize my "invasion". Thank you! |
RNHTTR
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KubernetesJobWatcher shadowing kube client timeouts arguments
Provided change allows to have previously established defaults in KubernetesJobWatcher for client timeouts to not hang on events reading, but also do not overwrite them if they were provided in specific configuration option by user.
closes: #45517
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.