-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more extensive test suite of nanoarrow usage #400
Comments
@paleolimbot would love to hear your thoughts here, or if you have alternative ideas! |
All of these are great ideas! Our CMake setup definitely needs improving...nanoarrow should definitely work in all the circumstances you listed. Adding some examples of CMake projects to the examples directory you linked would be very helpful...I don't have a lot of experience with how CMake is used in the wild but I am game to help make the examples build if you can provide them! |
… inclusion, and add proper tests (apache#406) Resolves apache#350. Resolves apache#400. Happy to reorganize things.
nanoarrow is designed to be a lightweight dependency easily consumed as part of the build process of its dependents. Although primarily designed around vendoring, in practice there are numerous ways in which a consumer might expect to be able to use nanoarrow, including:
NANOARROW_BUNDLE
flag on (automated by this GHA).Additionally, users may wish to use dynamic or static nanoarrow libraries.
Given this range of use cases, I think it would be very helpful to add explicit testing of usage of nanoarrow in different scenarios. A good way to do this would probably be to add more examples since it looks like those are also being built in CI. If there is interest in this. I am happy to volunteer my time to contribute some of these and improve nanoarrow's CMake along the way since I know CMake can be a bit tricky to work with. I can open issues and add associated examples + fixes as I find them. Handling this systematically would IMHO be a very useful way to increase consumer confidence in being able to use nanoarrow reliably.
The text was updated successfully, but these errors were encountered: