Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string view support #583

Closed
WillAyd opened this issue Aug 13, 2024 · 3 comments · Fixed by #596
Closed

Add string view support #583

WillAyd opened this issue Aug 13, 2024 · 3 comments · Fixed by #596

Comments

@WillAyd
Copy link
Contributor

WillAyd commented Aug 13, 2024

I've noticed polars in particular has started to export Arrow C data with the "vu" format string for string views, but I don't see any support for those in nanoarrow. Is this something that can be added easily? I think the same API we have in place for strings can be used for string views as well?

@bkietz probably knows more

@paleolimbot
Copy link
Member

@jorisvandenbossche started a PR for this ( #367 ) and recently the cudf maintainers were asking about it as well. It is a little tricky because the assumption of a finite number of buffers runs deep in the existing array view logic but I think Joris handled most of that already. I was planning to assess the complexity of adding it in the near term but if you have any interest in taking a stab at all or part of it feel free!

@WillAyd
Copy link
Contributor Author

WillAyd commented Aug 14, 2024

Sounds good. Will take a look if I get some free time

@paleolimbot
Copy link
Member

Great! No worries if you aren't able to get to it, but post a note here if you do so I don't step on your toes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants