Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI] Add r-devel/recheck workflow for doing reverse dependency checks on CI #43547

Closed
1 of 3 tasks
amoeba opened this issue Aug 3, 2024 · 3 comments · Fixed by #43784
Closed
1 of 3 tasks

[R][CI] Add r-devel/recheck workflow for doing reverse dependency checks on CI #43547

amoeba opened this issue Aug 3, 2024 · 3 comments · Fixed by #43784
Assignees
@amoeba
Labels
Component: Continuous Integration Component: R Type: enhancement
Milestone
19.0.0

Comments

@amoeba
Copy link
Member

amoeba commented Aug 3, 2024 •
edited
Loading

Describe the enhancement requested

Running reverse dependency checks is part of our CRAN packaging checklist (see such a list for 17.0.0). In the far past, one of us has run these checks locally which takes quite a bit of time. In the recent past, I've been running recheck which uses GHA to run similar checks and it's proven useful because it's faster and it appears to be accurate.

We should add the recheck workflow to our CI setup so R maintainers can run the workflow themselves. Recheck doesn't support checking a package in a subdirectory like we have here so there's one step before we can start using the workflow here.

Component(s)

Continuous Integration, R
@amoeba
Copy link
Member Author

amoeba commented Aug 3, 2024

PR filed against recheck, r-devel/recheck#6. We'll have to wait until that's available to do task two above.

@amoeba amoeba mentioned this issue Aug 21, 2024
Merged
@amoeba
Copy link
Member Author

amoeba commented Aug 21, 2024

Recheck now supports subdirs so I've filed #43784 add the workflow here.

amoeba added a commit that referenced this issue Nov 1, 2024
@amoeba
GH-43547: [R][CI] Add recheck workflow for checking reverse dependenc…
f3abc68 
…ies on GHA (#43784)

### Rationale for this change

See #43547.

### What changes are included in this PR?

Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: 

- `r-recheck-most` 
- `r-recheck-strong`

### Are these changes tested?

Yes. #44523 (comment).

### Are there any user-facing changes?

No.
* GitHub Issue: #43547

Fixes #43547.

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
@amoeba
Copy link
Member Author

amoeba commented Nov 1, 2024

Issue resolved by pull request 43784
#43784

@amoeba amoeba added this to the 19.0.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoeba amoeba

Labels
Component: Continuous Integration Component: R Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

Successfully merging a pull request may close this issue.

GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA amoeba/arrow
1 participant
@amoeba