GH-39982: [Java] Add RunEndEncodedVector #43888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViggoC
force-pushed
the
viggo/java-ree
branch
from
8cab62d
to
2d6eb89
Compare
lidavidm
reviewed
Sep 12, 2024
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/types/Types.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorDataVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/validate/TestValidateVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestRunEndEncodedVector.java
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Override | ||
| public void setNull(int index) { | ||
| throw new UnsupportedOperationException( |
There was a problem hiding this comment.
Hmm, we could splice the child, but let's ignore that for now
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting changes
Co-authored-by: David Li <[email protected]>
github-actions
bot
added
awaiting change review
lidavidm
approved these changes
Sep 18, 2024
| int rightLogicalIndex = range.getRightStart(); | ||
|
|
||
| while (leftLogicalIndex < leftRangeEnd) { | ||
| int leftPhysicalIndex = leftVector.getPhysicalIndex(leftLogicalIndex); |
There was a problem hiding this comment.
We can file a new issue for it and leave a TODO here.
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestRunEndEncodedVector.java
Show resolved
Hide resolved
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting change review
lidavidm
approved these changes
Sep 20, 2024
github-actions
bot
added
awaiting merge
lidavidm
reviewed
Sep 20, 2024
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
…ndEncodedVector.java
github-actions
bot
added
awaiting changes
lidavidm
reviewed
Sep 20, 2024
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
…ndEncodedVector.java
github-actions
bot
added
awaiting change review
lidavidm
reviewed
Sep 20, 2024
java/c/src/main/java/org/apache/arrow/c/BufferImportTypeVisitor.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting change review
|
@ViggoC thanks for getting this PR to the finish line. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d96d94. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?